Skip to content
This repository was archived by the owner on Dec 25, 2024. It is now read-only.

Fix for python issue 415#416

Merged
spacether merged 2 commits intomasterfrom
fix_issue_415
Apr 8, 2024
Merged

Fix for python issue 415#416
spacether merged 2 commits intomasterfrom
fix_issue_415

Conversation

@spacether
Copy link
Copy Markdown
Contributor

Fix for python issue 415

  • when generating optional properties, look deeply into all property schemas to see if they are inline or refed. The prior code just looked at the property and did not look deeper.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    mvn clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/generate_samples_configs/python*
    For Windows users, please run the script in Git BASH.

@spacether spacether linked an issue Apr 8, 2024 that may be closed by this pull request
6 tasks
@spacether spacether merged commit 3478fc1 into master Apr 8, 2024
@spacether spacether deleted the fix_issue_415 branch April 8, 2024 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][python] Reference Error when using schema with optional properties

1 participant